lkml.org 
[lkml]   [2022]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 204/411] video: fbdev: clcdfb: Fix refcount leak in clcdfb_of_vram_setup
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit b23789a59fa6f00e98a319291819f91fbba0deb8 ]

    of_parse_phandle() returns a node pointer with refcount incremented, we should
    use of_node_put() on it when not need anymore. Add missing of_node_put() to
    avoid refcount leak.

    Fixes: d10715be03bd ("video: ARM CLCD: Add DT support")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Signed-off-by: Helge Deller <deller@gmx.de>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/video/fbdev/amba-clcd.c | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    diff --git a/drivers/video/fbdev/amba-clcd.c b/drivers/video/fbdev/amba-clcd.c
    index 7de43be6ef2c..3b7a7c74bf0a 100644
    --- a/drivers/video/fbdev/amba-clcd.c
    +++ b/drivers/video/fbdev/amba-clcd.c
    @@ -774,12 +774,15 @@ static int clcdfb_of_vram_setup(struct clcd_fb *fb)
    return -ENODEV;

    fb->fb.screen_base = of_iomap(memory, 0);
    - if (!fb->fb.screen_base)
    + if (!fb->fb.screen_base) {
    + of_node_put(memory);
    return -ENOMEM;
    + }

    fb->fb.fix.smem_start = of_translate_address(memory,
    of_get_address(memory, 0, &size, NULL));
    fb->fb.fix.smem_len = size;
    + of_node_put(memory);

    return 0;
    }
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-13 13:25    [W:3.288 / U:0.204 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site