lkml.org 
[lkml]   [2022]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 176/411] pinctrl: mvebu: Fix irq_of_parse_and_map() return value
    Date
    From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

    [ Upstream commit 71bc7cf3be65bab441e03667cf215c557712976c ]

    The irq_of_parse_and_map() returns 0 on failure, not a negative ERRNO.

    Fixes: 2f227605394b ("pinctrl: armada-37xx: Add irqchip support")
    Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
    Link: https://lore.kernel.org/r/20220422105339.78810-1-krzysztof.kozlowski@linaro.org
    Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
    index f56add78d58c..359b2ecfcbdb 100644
    --- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
    +++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
    @@ -773,7 +773,7 @@ static int armada_37xx_irqchip_register(struct platform_device *pdev,
    for (i = 0; i < nr_irq_parent; i++) {
    int irq = irq_of_parse_and_map(np, i);

    - if (irq < 0)
    + if (!irq)
    continue;

    gpiochip_set_chained_irqchip(gc, irqchip, irq,
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-13 13:25    [W:4.296 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site