lkml.org 
[lkml]   [2022]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: r8188eu: put spaces after commas
On Sat, Jun 11, 2022 at 09:06:28PM -0700, daniel watson wrote:
> From: Daniel Watson <ozzloy@challenge-bot.com>
>
> conform to kernel style by putting spaces after commas
> this was found by checkpatch
>
> Signed-off-by: Daniel Watson <ozzloy@challenge-bot.com>
> ---
> drivers/staging/r8188eu/include/rtw_iol.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/include/rtw_iol.h b/drivers/staging/r8188eu/include/rtw_iol.h
> index fb88ebc1dabb1..b39ecfb75ade0 100644
> --- a/drivers/staging/r8188eu/include/rtw_iol.h
> +++ b/drivers/staging/r8188eu/include/rtw_iol.h
> @@ -50,13 +50,13 @@ int _rtw_IOL_append_WD_cmd(struct xmit_frame *xmit_frame, u16 addr,
> int _rtw_IOL_append_WRF_cmd(struct xmit_frame *xmit_frame, u8 rf_path,
> u16 addr, u32 value, u32 mask);
> #define rtw_IOL_append_WB_cmd(xmit_frame, addr, value, mask) \
> - _rtw_IOL_append_WB_cmd((xmit_frame), (addr), (value) ,(mask))
> + _rtw_IOL_append_WB_cmd((xmit_frame), (addr), (value), (mask))
> #define rtw_IOL_append_WW_cmd(xmit_frame, addr, value, mask) \
> - _rtw_IOL_append_WW_cmd((xmit_frame), (addr), (value),(mask))
> + _rtw_IOL_append_WW_cmd((xmit_frame), (addr), (value), (mask))
> #define rtw_IOL_append_WD_cmd(xmit_frame, addr, value, mask) \
> _rtw_IOL_append_WD_cmd((xmit_frame), (addr), (value), (mask))
> #define rtw_IOL_append_WRF_cmd(xmit_frame, rf_path, addr, value, mask) \
> - _rtw_IOL_append_WRF_cmd((xmit_frame),(rf_path), (addr), (value), (mask))
> + _rtw_IOL_append_WRF_cmd((xmit_frame), (rf_path), (addr), (value), (mask))

These #defines shouldn't even be needed, can you just remove them and
rename the _rtw_IOL_append_WRF_cmd() function to be
rtw_IOL_append_WRF_cmd() (and same for the others), as a patch series?

thanks,

greg k-h

\
 
 \ /
  Last update: 2022-06-12 06:56    [W:0.052 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site