Messages in this thread | | | Date | Sun, 12 Jun 2022 13:47:35 -0400 | From | Sasha Levin <> | Subject | Re: [PATCH AUTOSEL 5.10 21/38] accessiblity: speakup: Add missing misc_deregister in softsynth_probe |
| |
On Wed, Jun 08, 2022 at 11:08:30PM +0200, Pavel Machek wrote: >Hi! > >> From: Zheng Bin <zhengbin13@huawei.com> >> >> [ Upstream commit 106101303eda8f93c65158e5d72b2cc6088ed034 ] >> >> softsynth_probe misses a call misc_deregister() in an error path, this >> patch fixes that. > >This seems incorrect. Registration failed, we can't really deregister. > >I checked random other caller of misc_register(), and it does not seem >this API is unusual.
Uh, yes, I'll drop it for now.
-- Thanks, Sasha
| |