Messages in this thread | | | Date | Mon, 13 Jun 2022 01:03:31 +0800 | From | kernel test robot <> | Subject | [linux-stable-rc:queue/5.15 165/165] lib/iov_iter.c:1466:9: warning: comparison of distinct pointer types ('typeof (nr * (1UL << 16) - offset) *' (aka 'unsigned long *') and 'typeof (maxsize) *' (aka 'unsigned int *')) |
| |
tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git queue/5.15 head: 04983d84c84ee97abcab8bd9e6488790086cb082 commit: 04983d84c84ee97abcab8bd9e6488790086cb082 [165/165] iov_iter: Fix iter_xarray_get_pages{,_alloc}() config: hexagon-randconfig-r041-20220612 (https://download.01.org/0day-ci/archive/20220613/202206130107.hjrRK0jH-lkp@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 6466c9abf3674bade1f6ee859f24ebc7aaf9cd88) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=04983d84c84ee97abcab8bd9e6488790086cb082 git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git git fetch --no-tags linux-stable-rc queue/5.15 git checkout 04983d84c84ee97abcab8bd9e6488790086cb082 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> lib/iov_iter.c:1466:9: warning: comparison of distinct pointer types ('typeof (nr * (1UL << 16) - offset) *' (aka 'unsigned long *') and 'typeof (maxsize) *' (aka 'unsigned int *')) [-Wcompare-distinct-pointer-types] return min(nr * PAGE_SIZE - offset, maxsize); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/minmax.h:45:19: note: expanded from macro 'min' #define min(x, y) __careful_cmp(x, y, <) ^~~~~~~~~~~~~~~~~~~~~~ include/linux/minmax.h:36:24: note: expanded from macro '__careful_cmp' __builtin_choose_expr(__safe_cmp(x, y), \ ^~~~~~~~~~~~~~~~ include/linux/minmax.h:26:4: note: expanded from macro '__safe_cmp' (__typecheck(x, y) && __no_side_effects(x, y)) ^~~~~~~~~~~~~~~~~ include/linux/minmax.h:20:28: note: expanded from macro '__typecheck' (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1))) ~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~ lib/iov_iter.c:1630:9: warning: comparison of distinct pointer types ('typeof (nr * (1UL << 16) - offset) *' (aka 'unsigned long *') and 'typeof (maxsize) *' (aka 'unsigned int *')) [-Wcompare-distinct-pointer-types] return min(nr * PAGE_SIZE - offset, maxsize); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/minmax.h:45:19: note: expanded from macro 'min' #define min(x, y) __careful_cmp(x, y, <) ^~~~~~~~~~~~~~~~~~~~~~ include/linux/minmax.h:36:24: note: expanded from macro '__careful_cmp' __builtin_choose_expr(__safe_cmp(x, y), \ ^~~~~~~~~~~~~~~~ include/linux/minmax.h:26:4: note: expanded from macro '__safe_cmp' (__typecheck(x, y) && __no_side_effects(x, y)) ^~~~~~~~~~~~~~~~~ include/linux/minmax.h:20:28: note: expanded from macro '__typecheck' (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1))) ~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~ 2 warnings generated.
vim +1466 lib/iov_iter.c
1432 1433 static ssize_t iter_xarray_get_pages(struct iov_iter *i, 1434 struct page **pages, size_t maxsize, 1435 unsigned maxpages, size_t *_start_offset) 1436 { 1437 unsigned nr, offset; 1438 pgoff_t index, count; 1439 size_t size = maxsize; 1440 loff_t pos; 1441 1442 if (!size || !maxpages) 1443 return 0; 1444 1445 pos = i->xarray_start + i->iov_offset; 1446 index = pos >> PAGE_SHIFT; 1447 offset = pos & ~PAGE_MASK; 1448 *_start_offset = offset; 1449 1450 count = 1; 1451 if (size > PAGE_SIZE - offset) { 1452 size -= PAGE_SIZE - offset; 1453 count += size >> PAGE_SHIFT; 1454 size &= ~PAGE_MASK; 1455 if (size) 1456 count++; 1457 } 1458 1459 if (count > maxpages) 1460 count = maxpages; 1461 1462 nr = iter_xarray_populate_pages(pages, i->xarray, index, count); 1463 if (nr == 0) 1464 return 0; 1465 > 1466 return min(nr * PAGE_SIZE - offset, maxsize); 1467 } 1468
-- 0-DAY CI Kernel Test Service https://01.org/lkp
| |