Messages in this thread | | | Subject | Re: [PATCH] mm/shmem.c: use helper transhuge_vma_enabled() | From | Miaohe Lin <> | Date | Sat, 11 Jun 2022 14:32:30 +0800 |
| |
On 2022/6/11 11:14, Hugh Dickins wrote: > On Sat, 11 Jun 2022, Miaohe Lin wrote: > >> Use helper transhuge_vma_enabled() to check whether transhuge is enable >> on vma. Minor readability improvement. >> >> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> > > No thanks, that's a readability regression, forcing reader > to go and look up what transhuge_vma_enabled() actually means. > > What you call a helper, I call an obfuscator - as I implied in > b9e2faaf6fa0 ("huge tmpfs: revert shmem's use of transhuge_vma_enabled()")
Oh, that commit also cc to me. But I forgot it... Sorry.
> > Hugh >
| |