lkml.org 
[lkml]   [2022]   [Jun]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next v1 1/1] net: phy: add remote fault support
> --- a/include/uapi/linux/ethtool.h
> +++ b/include/uapi/linux/ethtool.h
> @@ -1840,6 +1840,46 @@ static inline int ethtool_validate_duplex(__u8 duplex)
> #define MASTER_SLAVE_STATE_SLAVE 3
> #define MASTER_SLAVE_STATE_ERR 4
>
> +#define REMOTE_FAULT_CFG_UNSUPPORTED 0
> +#define REMOTE_FAULT_CFG_UNKNOWN 1
> +#define REMOTE_FAULT_CFG_NO_ERROR 2
> +/* IEEE 802.3-2018 28.2.1.2.4 Fault without additional information */
> +#define REMOTE_FAULT_CFG_ERROR 3
> +/* IEEE 802.3-2018 28C.5 Message code 4: 0 - RF Test */
> +#define REMOTE_FAULT_CFG_TEST 4
> +/* IEEE 802.3-2018 28C.5 Message code 4: 1 - Link Loss */
> +#define REMOTE_FAULT_CFG_LINK_LOSS 5
> +/* IEEE 802.3-2018 28C.5 Message code 4: 2 - Jabber */
> +#define REMOTE_FAULT_CFG_JABBER 6
> +/* IEEE 802.3-2018 28C.5 Message code 4: 3 - Parallel Detection Fault */
> +#define REMOTE_FAULT_CFG_PDF 7
> +/* IEEE 802.3-2018 37.2.1.5.2 Offline */
> +#define REMOTE_FAULT_CFG_OFFLINE 8
> +/* IEEE 802.3-2018 37.2.1.5.3 Link_Failure */
> +#define REMOTE_FAULT_CFG_LINK_FAIL 9
> +/* IEEE 802.3-2018 37.2.1.5.4 Auto-Negotiation_Error */
> +#define REMOTE_FAULT_CFG_AN_ERROR 10
> +
> +#define REMOTE_FAULT_STATE_UNSUPPORTED 0
> +#define REMOTE_FAULT_STATE_UNKNOWN 1
> +#define REMOTE_FAULT_STATE_NO_ERROR 2
> +/* IEEE 802.3-2018 28.2.1.2.4 Fault without additional information */
> +#define REMOTE_FAULT_STATE_ERROR 3
> +/* IEEE 802.3-2018 28C.5 Message code 4: 0 - RF Test */
> +#define REMOTE_FAULT_STATE_TEST 4
> +/* IEEE 802.3-2018 28C.5 Message code 4: 1 - Link Loss */
> +#define REMOTE_FAULT_STATE_LINK_LOSS 5
> +/* IEEE 802.3-2018 28C.5 Message code 4: 2 - Jabber */
> +#define REMOTE_FAULT_STATE_JABBER 6
> +/* IEEE 802.3-2018 28C.5 Message code 4: 3 - Parallel Detection Fault */
> +#define REMOTE_FAULT_STATE_PDF 7
> +/* IEEE 802.3-2018 37.2.1.5.2 Offline */
> +#define REMOTE_FAULT_STATE_OFFLINE 8
> +/* IEEE 802.3-2018 37.2.1.5.3 Link_Failure */
> +#define REMOTE_FAULT_STATE_LINK_FAIL 9
> +/* IEEE 802.3-2018 37.2.1.5.4 Auto-Negotiation_Error */
> +#define REMOTE_FAULT_STATE_AN_ERROR 10

I'm not sure there is any value in having these values twice. They are
expected to be identical, so one set should be enough.

Andrew

\
 
 \ /
  Last update: 2022-06-11 17:51    [W:0.282 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site