Messages in this thread | | | From | "Alejandro T." <> | Subject | Re: [PATCH] arm64/sysreg: Fix typo in Enum element regex | Date | Fri, 10 Jun 2022 14:50:18 +0200 |
| |
On viernes, 10 de junio de 2022 13:19:50 (CEST) Mark Brown wrote: > On Fri, Jun 10, 2022 at 10:15:04AM +0100, Catalin Marinas wrote: > > On Thu, Jun 09, 2022 at 10:42:18PM +0200, Alejandro Tafalla wrote: > > > In the awk script, there was a typo with the comparison operator when > > > checking if the matched pattern is inside an Enum block. > > > This prevented the generation of the whole sysreg-defs.h header. > > > > > > -/0b[01]+/ && block = "Enum" { > > > +/0b[01]+/ && block == "Enum" { > > > > This makes sense but I'm surprised that we haven't noticed it until now > > (maybe some awk versions treat it as a relational operator). > > What Catlain said - if we weren't generating the full header contents > I'd expect things to fail to build normally, but it's entirely possible > this is just happening to work with some implementations and the patch > is clearly correct. > > Reviewed-by: Mark Brown <broonie@kernel.org>
Hi Mark, thanks for your review.
Indeed, I'm building the kernel in Alpine, which uses Busybox instead of gawk.
| |