lkml.org 
[lkml]   [2022]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] arm64/sysreg: Fix typo in Enum element regex
On Fri, Jun 10, 2022 at 10:15:04AM +0100, Catalin Marinas wrote:
> On Thu, Jun 09, 2022 at 10:42:18PM +0200, Alejandro Tafalla wrote:

> > In the awk script, there was a typo with the comparison operator when
> > checking if the matched pattern is inside an Enum block.
> > This prevented the generation of the whole sysreg-defs.h header.

> > -/0b[01]+/ && block = "Enum" {
> > +/0b[01]+/ && block == "Enum" {

> This makes sense but I'm surprised that we haven't noticed it until now
> (maybe some awk versions treat it as a relational operator).

What Catlain said - if we weren't generating the full header contents
I'd expect things to fail to build normally, but it's entirely possible
this is just happening to work with some implementations and the patch
is clearly correct.

Reviewed-by: Mark Brown <broonie@kernel.org>
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2022-06-10 13:20    [W:0.048 / U:0.808 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site