Messages in this thread Patch in this message | | | From | Clément Léger <> | Subject | [PATCH net-next v7 01/16] net: dsa: allow port_bridge_join() to override extack message | Date | Fri, 10 Jun 2022 12:28:18 +0200 |
| |
Some drivers might report that they are unable to bridge ports by returning -EOPNOTSUPP, but still wants to override extack message. In order to do so, in dsa_slave_changeupper(), if port_bridge_join() returns -EOPNOTSUPP, check if extack message is set and if so, do not override it.
Reviewed-by: Vladimir Oltean <olteanv@gmail.com> Signed-off-by: Clément Léger <clement.leger@bootlin.com> --- net/dsa/slave.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/net/dsa/slave.c b/net/dsa/slave.c index 2e1ac638d135..509b98dd9954 100644 --- a/net/dsa/slave.c +++ b/net/dsa/slave.c @@ -2460,8 +2460,9 @@ static int dsa_slave_changeupper(struct net_device *dev, if (!err) dsa_bridge_mtu_normalization(dp); if (err == -EOPNOTSUPP) { - NL_SET_ERR_MSG_MOD(extack, - "Offloading not supported"); + if (!extack->_msg) + NL_SET_ERR_MSG_MOD(extack, + "Offloading not supported"); err = 0; } err = notifier_from_errno(err); -- 2.36.1
| |