lkml.org 
[lkml]   [2022]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH V6 2/2] rtc: zynqmp: Add calibration set and get support
Date
>>>>> "Neeli," == Neeli, Srinivas <srinivas.neeli@amd.com> writes:

Hi,

>> >> Where do you see that? ug1085 rev2.2 still lists:
>> >>
>> >> Programming Sequences
>> >> init rtc
>> >> 1. Write the value 0019_8231h into the calibration register, CALIB_WRITE.
>> >>
>>
>> > This is a very weird value. Last time I had a look, I couldn't find an >
>> explanation for it.
>>
>> Agreed. I am not arguing that it is sensible, I just wondered where this new
>> value comes from?
>>
> This information is missing in our TRM, as per the internal RTC IP
> design specification document, the calibration value should be crystal
> clock frequency minus one.
> For a crystal oscillator of 32.768KHz(0x8000) frequency, the calibration value will be 0x7FFF.

> Will update TRM with the required information.

Ok, great!

Please put this change in a separate commit from the get/set logic.

--
Bye, Peter Korsgaard

\
 
 \ /
  Last update: 2022-06-10 12:13    [W:0.101 / U:0.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site