Messages in this thread Patch in this message | | | Date | Fri, 10 Jun 2022 07:51:22 +0200 | Subject | Re: [PATCH] staging: olpc_dcon: mark driver as broken | From | Thomas Zimmermann <> |
| |
Am 10.06.22 um 00:34 schrieb Javier Martinez Canillas: > The commit eecb3e4e5d9d ("staging: olpc_dcon: add OLPC display controller > (DCON) support") added this driver in 2010, and has been in staging since > then. It was marked as broken at some point because it didn't even build > but that got removed once the build issues were addressed. > > But it seems that the work to move this driver out of staging has stalled, > the last non-trivial change to fix one of the items mentioned in its todo > file was commit e40219d5e4b2 ("staging: olpc_dcon: allow simultaneous XO-1 > and XO-1.5 support") in 2019. > > And even if work to destage the driver is resumed, the fbdev subsystem has > been deprecated for a long time and instead it should be ported to DRM. > > Now this driver is preventing to land a kernel wide change, that makes the > num_registered_fb symbol to be private to the fbmem.c file. > > So let's just mark the driver as broken. Someone can then work on making > it not depend on the num_registered_fb symbol, allowing to drop the broken > dependency again. > > Suggested-by: Sam Ravnborg <sam@ravnborg.org> > Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
> --- > > drivers/staging/olpc_dcon/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/olpc_dcon/Kconfig b/drivers/staging/olpc_dcon/Kconfig > index d1a0dea09ef0..d0ba34cc32f7 100644 > --- a/drivers/staging/olpc_dcon/Kconfig > +++ b/drivers/staging/olpc_dcon/Kconfig > @@ -1,7 +1,7 @@ > # SPDX-License-Identifier: GPL-2.0 > config FB_OLPC_DCON > tristate "One Laptop Per Child Display CONtroller support" > - depends on OLPC && FB > + depends on OLPC && FB && BROKEN > depends on I2C > depends on GPIO_CS5535 && ACPI > select BACKLIGHT_CLASS_DEVICE
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Ivo Totev [unhandled content-type:application/pgp-signature]
| |