lkml.org 
[lkml]   [2022]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/2] bus: bt1-apb: Don't print error on -EPROBE_DEFER
From
Date
Hi Serge,

On Fr, 2022-06-10 at 11:01 +0300, Serge Semin wrote:
> The Baikal-T1 APB bus driver correctly handles the deferred probe
> situation, but still pollutes the system log with a misleading error
> message. Let's fix that by using the dev_err_probe() method to print the
> log message in case of the clocks/resets request errors.
>
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> ---
>  drivers/bus/bt1-apb.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/bus/bt1-apb.c b/drivers/bus/bt1-apb.c
> index b25ff941e7c7..ac13b5b97107 100644
> --- a/drivers/bus/bt1-apb.c
> +++ b/drivers/bus/bt1-apb.c
> @@ -176,7 +176,8 @@ static int bt1_apb_request_rst(struct bt1_apb *apb)
>  
>
>
>
>   apb->prst = devm_reset_control_get_optional_exclusive(apb->dev, "prst");
>   if (IS_ERR(apb->prst)) {
> - dev_warn(apb->dev, "Couldn't get reset control line\n");
> + dev_err_probe(apb->dev, PTR_ERR(apb->prst),
> + "Couldn't get reset control line\n");
>   return PTR_ERR(apb->prst);

This could be shortened to

- dev_warn(apb->dev, "Couldn't get reset control line\n");
+ return dev_err_probe(apb->dev, PTR_ERR(apb->prst),
+ "Couldn't get reset control line\n");
- return PTR_ERR(apb->prst);

regards
Philipp

\
 
 \ /
  Last update: 2022-06-10 11:36    [W:2.075 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site