Messages in this thread | | | Date | Fri, 10 Jun 2022 10:28:08 +0200 | From | Vasant Karasulli <> | Subject | Re: [PATCH v6 2/4] x86/tests: Add tests for AMD SEV-ES #VC handling Add KUnit based tests to validate Linux's VC handling for instructions cpuid and wbinvd. These tests: 1. install a kretprobe on the #VC handler (sev_es_ghcb_hv_call, to access GHCB befor |
| |
On Mi 08-06-22 19:57:45, Sean Christopherson wrote: > On Wed, Jun 08, 2022, Vasant Karasulli wrote: > > On Mi 08-06-22 14:35:55, Sean Christopherson wrote: > > > On Wed, Jun 08, 2022, Vasant Karasulli wrote: > > > > On Mi 06-04-22 01:22:55, Sean Christopherson wrote: > > > > > > + if (ret) { > > > > > > + kunit_info(test, "Could not register kretprobe. Skipping."); > > > > > > + goto out; > > > > > > + } > > > > > > + > > > > > > + test->priv = kunit_kzalloc(test, sizeof(u64), GFP_KERNEL); > > > > > > > > > > Allocating 8 bytes and storing the pointer an 8-byte field is rather pointless :-) > > > > > > > > > > > > > Actually it's necessary to allocate memory to test->priv before using according to > > > > https://www.kernel.org/doc/html/latest/dev-tools/kunit/tips.html > > > > > > If priv points at structure of some form, sure, but you're storing a simple value. > > > > Yes, I agree. The reason it was done this way I guess is that type of priv is a > > void pointer and storing a u64 value results in a compiler warning: > > cast from pointer to integer of different size [-Wpointer-to-int-cast]. > > An intermediate cast to "unsigned long" should make that go away.
Yes, intermediate cast satisfied the compiler. Thanks for the tip.
-- Vasant Karasulli Kernel generalist www.suse.com<http://www.suse.com> [https://www.suse.com/assets/img/social-platforms-suse-logo.png]<http://www.suse.com/> SUSE - Open Source Solutions for Enterprise Servers & Cloud<http://www.suse.com/> Modernize your infrastructure with SUSE Linux Enterprise servers, cloud technology for IaaS, and SUSE's software-defined storage. www.suse.com
| |