Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Fri, 10 Jun 2022 10:24:12 +0200 | Subject | Re: [PATCH] m68k: mac: Fix typo in comment |
| |
Hi Xiang,
On Fri, Jun 10, 2022 at 10:22 AM Xiang wangx <wangxiang@cdjrlc.com> wrote: > Delete the redundant word 'an'. > Delete the redundant word 'and'. > > Signed-off-by: Xiang wangx <wangxiang@cdjrlc.com>
Thanks for your patch!
> --- a/arch/m68k/mac/iop.c > +++ b/arch/m68k/mac/iop.c > @@ -25,7 +25,7 @@ > * check this.) > * 990605 (jmt) - Rearranged things a bit wrt IOP detection; iop_present is > * gone, IOP base addresses are now in an array and the > - * globally-visible functions take an IOP number instead of an > + * globally-visible functions take an IOP number instead of
OK
> * an actual base address. > * 990610 (jmt) - Finished the message passing framework and it seems to work. > * Sending _definitely_ works; my adb-bus.c mods can send > @@ -66,7 +66,7 @@ > * a shared memory area in the IOP RAM. Each IOP has seven "channels"; each > * channel is connected to a specific software driver on the IOP. For example > * on the SCC IOP there is one channel for each serial port. Each channel has > - * an incoming and and outgoing message queue with a depth of one. > + * an incoming and outgoing message queue with a depth of one.
The second "and" should not be deleted, but replaced by "an".
> * > * A message is 32 bytes plus a state byte for the channel (MSG_IDLE, MSG_NEW, > * MSG_RCVD, MSG_COMPLETE). To send a message you copy the message into the
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |