Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Fri, 10 Jun 2022 10:04:38 +0200 | Subject | Re: [PATCH v2] thermal: rcar_gen3_thermal: improve logging during probe |
| |
Hi Wolfram,
On Thu, Jun 9, 2022 at 10:23 PM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > When setting up a new board, a plain "Can't register thermal zone" > didn't help me much because the thermal zones in DT were all fine. I > just had a sensor entry too much in the parent TSC node. Reword the > failure/success messages to contain the sensor number to make it easier > to understand which sensor is affected. Example output now: > > rcar_gen3_thermal e6198000.thermal: Sensor 0: Loaded 1 trip point > rcar_gen3_thermal e6198000.thermal: Sensor 1: Loaded 1 trip point > rcar_gen3_thermal e6198000.thermal: Sensor 2: Loaded 1 trip point > rcar_gen3_thermal e6198000.thermal: Sensor 3: Can't register thermal zone > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > --- > > Change from v1: reword the dev_info string to be more like the original > one. Added a check to add the plural-'s' only when needed.
Thanks for the update!
> Geert: is this better now?
Much better!
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |