lkml.org 
[lkml]   [2022]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4/5] mmc: sdhci-of-arasan: Obviously always return success in remove callback
    Date
    sdhci_pltfm_unregister() returns 0 unconditionally and returning an
    error in a platform remove callback isn't very sensible. (The only
    effect of the latter is that the device core emits a generic warning and
    then removes the device anyhow.)

    So return 0 unconditionally to make it obvious there is no error
    forwarded to the upper layers.

    This is a preparation for making platform remove callbacks return void.

    Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    ---
    drivers/mmc/host/sdhci-of-arasan.c | 5 ++---
    1 file changed, 2 insertions(+), 3 deletions(-)

    diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
    index 757801dfc308..3997cad1f793 100644
    --- a/drivers/mmc/host/sdhci-of-arasan.c
    +++ b/drivers/mmc/host/sdhci-of-arasan.c
    @@ -1733,7 +1733,6 @@ static int sdhci_arasan_probe(struct platform_device *pdev)

    static int sdhci_arasan_remove(struct platform_device *pdev)
    {
    - int ret;
    struct sdhci_host *host = platform_get_drvdata(pdev);
    struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
    struct sdhci_arasan_data *sdhci_arasan = sdhci_pltfm_priv(pltfm_host);
    @@ -1747,11 +1746,11 @@ static int sdhci_arasan_remove(struct platform_device *pdev)

    sdhci_arasan_unregister_sdclk(&pdev->dev);

    - ret = sdhci_pltfm_unregister(pdev);
    + sdhci_pltfm_unregister(pdev);

    clk_disable_unprepare(clk_ahb);

    - return ret;
    + return 0;
    }

    static struct platform_driver sdhci_arasan_driver = {
    --
    2.36.1
    \
     
     \ /
      Last update: 2022-06-10 23:16    [W:6.795 / U:0.520 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site