lkml.org 
[lkml]   [2022]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v1 1/3] gpio: crystalcove: make irq_chip immutable
On Wed, Jun 1, 2022 at 5:04 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:

...

> + gpiochip_enable_irq(gc, hwirq);

I think we do not need to do this for pins that we do not touch as
IRQs (they are vGPIOs with GPE capabilities, AFAIR).

> - if (data->hwirq < CRYSTALCOVE_GPIO_NUM) {
> + if (hwirq < CRYSTALCOVE_GPIO_NUM) {
> cg->set_irq_mask = false;
> cg->update |= UPDATE_IRQ_MASK;
> }

...

> - if (data->hwirq < CRYSTALCOVE_GPIO_NUM) {
> + if (hwirq < CRYSTALCOVE_GPIO_NUM) {
> cg->set_irq_mask = true;
> cg->update |= UPDATE_IRQ_MASK;
> }
> +
> + gpiochip_disable_irq(gc, hwirq);

Ditto.

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2022-06-01 17:50    [W:0.040 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site