Messages in this thread | | | Date | Wed, 1 Jun 2022 16:33:20 +0100 | Subject | Re: [PATCH 3/3] thermal/sysfs: Remove cooling device sysfs statistics | From | Lukasz Luba <> |
| |
Hi Daniel,
On 6/1/22 16:14, Daniel Lezcano wrote: > The statistics are for debugging purpose and belong to debugfs rather > than sysfs. As the previous changes introduced the same statistics in > debugfs, those in sysfs are no longer needed and can be removed.
I just want to let you know that in current Android kernels we cannot even compile the kernel with CONFIG_DEBUG_FS. I have this pain with Energy Model there... Some vendors might see useful info via this sysfs interface in bring-up of the SoC.
I don't know if there are user-space tools tracking this information via sysfs. We probably should check that.
I agree that these statistics look more like debug info, rather than something useful for control.
Furthermore, we have trace events for the cooling state changes, which should be good enough for bring-up and experiments.
I don't have strong preferences here. I tend to agree to remove this interface if there are no user-space tools using it.
Regards, Lukasz
| |