Messages in this thread | | | Date | Wed, 1 Jun 2022 14:42:30 +0100 | Subject | Re: [PATCH v2] ASoC: qcom: soundwire: Add support for controlling audio CGCR from HLOS | From | Srinivas Kandagatla <> |
| |
On 01/06/2022 14:15, Srinivasa Rao Mandadapu wrote: >>>>>>> + ctrl->audio_cgcr = devm_reset_control_get_exclusive(dev, >>>>>>> "swr_audio_cgcr"); >>>>>>> + if (IS_ERR(ctrl->audio_cgcr)) >>>>>>> + dev_err(dev, "Failed to get audio_cgcr reset >>>>>>> required for soundwire-v1.6.0\n"); >>>>>> Why is there no return on error here? Is the reset optional? >>>>> Yes it's optional. For older platforms this is not required. >>>> If it's optional then either there should be no error message, or the >>>> error message should only be logged when the version is >= 1.6.0. There >>>> are few things worse than a kernel log riddled with misleading error >>>> messages. >>> >>> In that case, it can be done like below. Kindly let me know your >>> opinion on this. >>> >>> if (ctrl->version >= 0x01060000) { >> >> This is not true 1.7+ variants do not require anything as such. > > I think it applies for all upcoming versions as Qualcomm Hardware team. > Here is the not from HW Team.
Am testing sm8450 which has 1.7.0 and it does not require/have such control.
I dont understand what is the issue in adding a flag to struct qcom_swrm_data.
This should give finer control rather than matching anything > 1.6.
--srini >
| |