Messages in this thread | | | Date | Wed, 1 Jun 2022 18:38:44 +0800 | Subject | Re: [PATCH 06/12] iommu/vt-d: Acquiring lock in domain ID allocation helpers | From | Baolu Lu <> |
| |
Hi Kevin,
Thank you for the comments.
On 2022/6/1 17:09, Tian, Kevin wrote: >> From: Lu Baolu<baolu.lu@linux.intel.com> >> Sent: Friday, May 27, 2022 2:30 PM >> >> The iommu->lock is used to protect the per-IOMMU domain ID resource. >> Move the spinlock acquisition/release into the helpers where domain >> IDs are allocated and freed. The device_domain_lock is irrelevant to >> domain ID resources, remove its assertion as well. > while moving the lock you also replace spin_lock_irqsave() with spin_lock(). > It'd be cleaner to just do movement here and then replace all _irqsave() > in patch 8.
Yeah, that will be clearer.
Best regards, baolu
| |