Messages in this thread | | | Date | Wed, 1 Jun 2022 05:01:28 -0500 | Subject | Re: [PATCH] staging: r8188eu: Drop redundant memset | From | Larry Finger <> |
| |
On 6/1/22 04:35, Haowen Bai wrote: > The region set by the call to memset is immediately overwritten by the > subsequent call to memcpy. So we drop redundant memset. > > Signed-off-by: Haowen Bai <baihaowen@meizu.com> > --- > drivers/staging/r8188eu/core/rtw_mlme.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/staging/r8188eu/core/rtw_mlme.c b/drivers/staging/r8188eu/core/rtw_mlme.c > index 5a815642c3f6..56c8bd5f4c60 100644 > --- a/drivers/staging/r8188eu/core/rtw_mlme.c > +++ b/drivers/staging/r8188eu/core/rtw_mlme.c > @@ -676,7 +676,6 @@ void rtw_surveydone_event_callback(struct adapter *adapter, u8 *pbuf) > > _clr_fwstate_(pmlmepriv, _FW_UNDER_SURVEY); > > - memset(&pdev_network->Ssid, 0, sizeof(struct ndis_802_11_ssid)); > memcpy(&pdev_network->Ssid, &pmlmepriv->assoc_ssid, sizeof(struct ndis_802_11_ssid)); > > rtw_update_registrypriv_dev_network(adapter); > @@ -1253,7 +1252,6 @@ void rtw_stadel_event_callback(struct adapter *adapter, u8 *pbuf) > > memcpy(pdev_network, &tgt_network->network, get_wlan_bssid_ex_sz(&tgt_network->network)); > > - memset(&pdev_network->Ssid, 0, sizeof(struct ndis_802_11_ssid)); > memcpy(&pdev_network->Ssid, &pmlmepriv->assoc_ssid, sizeof(struct ndis_802_11_ssid)); > > rtw_update_registrypriv_dev_network(adapter);
You supplied two patches with the same subject that do different things. That is confusing to everyone. Please redo with unique subjects.
Larry
| |