lkml.org 
[lkml]   [2022]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 0/8] Add a panel API to return panel orientation
    From
    Hi,

    On 6/1/22 10:18, Hsin-Yi Wang wrote:
    > Panels usually call drm_connector_set_panel_orientation(), which is
    > later than drm/kms driver calling drm_dev_register(). This leads to a
    > WARN()[1].
    >
    > The orientation property is known earlier. For example, some panels
    > parse the property through device tree during probe.
    >
    > The series add a panel API drm_panel_get_orientation() for drm/kms
    > drivers. The drivers can use the API to get panel's orientation, so they
    > can call drm_connector_set_panel_orientation() before drm_dev_register().
    >
    > Panel needs to implement .get_orientation callback to return the property.
    >
    > [1] https://patchwork.kernel.org/project/linux-mediatek/patch/20220530081910.3947168-2-hsinyi@chromium.org/

    Thank you for implementing this.

    Patches 1-7 look good to me:

    Reviewed-by: Hans de Goede <hdegoede@redhat.com>

    I've a few small remarks on patch 8, see my reply
    to that patch.

    Regards,

    Hans


    >
    > Hsin-Yi Wang (8):
    > drm/panel: Add an API drm_panel_get_orientation() to return panel
    > orientation
    > drm/panel: boe-tv101wum-nl6: Implement .get_orientation callback
    > drm/panel: panel-edp: Implement .get_orientation callback
    > drm/panel: lvds: Implement .get_orientation callback
    > drm/panel: panel-simple: Implement .get_orientation callback
    > drm/panel: ili9881c: Implement .get_orientation callback
    > drm/panel: elida-kd35t133: Implement .get_orientation callback
    > drm/mediatek: Config orientation property if panel provides it
    >
    > drivers/gpu/drm/drm_panel.c | 8 ++++++++
    > drivers/gpu/drm/mediatek/mtk_dsi.c | 14 ++++++++++++++
    > drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c | 8 ++++++++
    > drivers/gpu/drm/panel/panel-edp.c | 8 ++++++++
    > drivers/gpu/drm/panel/panel-elida-kd35t133.c | 8 ++++++++
    > drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 8 ++++++++
    > drivers/gpu/drm/panel/panel-lvds.c | 8 ++++++++
    > drivers/gpu/drm/panel/panel-simple.c | 9 +++++++++
    > include/drm/drm_panel.h | 10 ++++++++++
    > 9 files changed, 81 insertions(+)
    >

    \
     
     \ /
      Last update: 2022-06-01 10:52    [W:4.347 / U:0.132 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site