Messages in this thread | | | From | Miles Chen <> | Subject | Re: [PATCH v3] PCI: mediatek-gen3: Fix refcount leak in mtk_pcie_init_irq_domains | Date | Wed, 1 Jun 2022 12:47:36 +0800 |
| |
Hi Miaoqian,
>of_get_child_by_name() returns a node pointer with refcount >incremented, we should use of_node_put() on it when not need anymore. >Add missing of_node_put() to avoid refcount leak. > >Fixes: 814cceebba9b ("PCI: mediatek-gen3: Add INTx support") >Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Thanks for scanning the refcont leak and submitting this!
Reviewed-by: Miles Chen <miles.chen@mediatek.com>
>--- >changes in v2: >- move of_node_put(intc_node) right after irq_domain_add_linear to cover >normal path and error paths. >--- >changes in v3: >- call of_node_put() in error paths with goto, and call of_node_put() before > return 0 in normal path. Since this function has a goto part to handle > resources, so put them together, as suggested by Miles Chen <miles.chen@mediatek.com> > >v1 link: https://lore.kernel.org/all/20220526110246.53502-1-linmq006@gmail.com/ >v2 link: https://lore.kernel.org/all/20220530064807.34534-1-linmq006@gmail.com/
| |