lkml.org 
[lkml]   [2022]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 2/3] dt-bindings: display: Add bindings for ClockworkPi CWD686
From
On 01/06/2022 07:17, Max Fierke wrote:

Subject: remove word "bindings" because you duplicate prefix, so
"dt-bindings: display: Add ClockworkPi CWD686 panel".


> +required:
> + - compatible
> + - reg
> + - backlight
> + - reset-gpios
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + backlight: backlight {
> + compatible = "gpio-backlight";
> + gpios = <&gpio4 30 GPIO_ACTIVE_HIGH>;
> + };

No need for backlight example, it is trivial/same for everyone.

With that removed:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

> +
> + dsi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + panel@0 {
> + compatible = "clockworkpi,cwd686";
> + reg = <0>;
> + backlight = <&backlight>;
> + reset-gpios = <&gpio2 28 GPIO_ACTIVE_HIGH>;
> + rotation = <90>;
> + };
> + };


Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-06-01 09:50    [W:0.089 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site