lkml.org 
[lkml]   [2022]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v8 1/3] dt-bindings: phy: qcom,usb-snps-femto-v2: Add phy override params bindings
From
Thanks Rob !


On 6/1/2022 11:03 PM, Rob Herring wrote:
> On Wed, Jun 01, 2022 at 07:28:53AM -0500, Rob Herring wrote:
>> On Wed, 01 Jun 2022 12:26:02 +0530, Krishna Kurapati wrote:
>>> From: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
>>>
>>> Add device tree bindings for SNPS phy tuning parameters.
>>>
>>> Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
>>> Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com>
>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>> ---
>>> .../bindings/phy/qcom,usb-snps-femto-v2.yaml | 96 ++++++++++++++++++++++
>>> 1 file changed, 96 insertions(+)
>>>
>> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
>> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>>
>> yamllint warnings/errors:
>>
>> dtschema/dtc warnings/errors:
>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: properties:qcom,hs-rise-fall-time-bp: 'oneOf' conditional failed, one must be fixed:
>> 'type' is a required property
>> hint: A vendor boolean property can use "type: boolean"
>> Additional properties are not allowed ('maximum', 'minimum' were unexpected)
>> hint: A vendor boolean property can use "type: boolean"
>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: properties:qcom,hs-rise-fall-time-bp: 'oneOf' conditional failed, one must be fixed:
>> 'enum' is a required property
>> 'const' is a required property
>> hint: A vendor string property with exact values has an implicit type
>> from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: properties:qcom,hs-rise-fall-time-bp: 'oneOf' conditional failed, one must be fixed:
>> '$ref' is a required property
>> 'allOf' is a required property
>> hint: A vendor property needs a $ref to types.yaml
>> from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
>> hint: Vendor specific properties must have a type and description unless they have a defined, common suffix.
>> from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: properties:qcom,ls-fs-output-impedance-bp: 'oneOf' conditional failed, one must be fixed:
>> 'type' is a required property
>> hint: A vendor boolean property can use "type: boolean"
>> Additional properties are not allowed ('maximum', 'minimum' were unexpected)
>> hint: A vendor boolean property can use "type: boolean"
>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: properties:qcom,ls-fs-output-impedance-bp: 'oneOf' conditional failed, one must be fixed:
>> 'enum' is a required property
>> 'const' is a required property
>> hint: A vendor string property with exact values has an implicit type
>> from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: properties:qcom,ls-fs-output-impedance-bp: 'oneOf' conditional failed, one must be fixed:
>> '$ref' is a required property
>> 'allOf' is a required property
>> hint: A vendor property needs a $ref to types.yaml
>> from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
>> hint: Vendor specific properties must have a type and description unless they have a defined, common suffix.
>> from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: properties:qcom,pre-emphasis-amplitude-bp: 'oneOf' conditional failed, one must be fixed:
>> 'type' is a required property
>> hint: A vendor boolean property can use "type: boolean"
>> Additional properties are not allowed ('maximum', 'minimum' were unexpected)
>> hint: A vendor boolean property can use "type: boolean"
>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: properties:qcom,pre-emphasis-amplitude-bp: 'oneOf' conditional failed, one must be fixed:
>> 'enum' is a required property
>> 'const' is a required property
>> hint: A vendor string property with exact values has an implicit type
>> from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: properties:qcom,pre-emphasis-amplitude-bp: 'oneOf' conditional failed, one must be fixed:
>> '$ref' is a required property
>> 'allOf' is a required property
>> hint: A vendor property needs a $ref to types.yaml
>> from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
>> hint: Vendor specific properties must have a type and description unless they have a defined, common suffix.
>> from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: properties:qcom,squelch-detector-bp: 'oneOf' conditional failed, one must be fixed:
>> 'type' is a required property
>> hint: A vendor boolean property can use "type: boolean"
>> Additional properties are not allowed ('maximum', 'minimum' were unexpected)
>> hint: A vendor boolean property can use "type: boolean"
>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: properties:qcom,squelch-detector-bp: 'oneOf' conditional failed, one must be fixed:
>> 'enum' is a required property
>> 'const' is a required property
>> hint: A vendor string property with exact values has an implicit type
>> from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: properties:qcom,squelch-detector-bp: 'oneOf' conditional failed, one must be fixed:
>> '$ref' is a required property
>> 'allOf' is a required property
>> hint: A vendor property needs a $ref to types.yaml
>> from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
>> hint: Vendor specific properties must have a type and description unless they have a defined, common suffix.
>> from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: properties:qcom,hs-disconnect-bp: 'oneOf' conditional failed, one must be fixed:
>> 'type' is a required property
>> hint: A vendor boolean property can use "type: boolean"
>> Additional properties are not allowed ('maximum', 'minimum' were unexpected)
>> hint: A vendor boolean property can use "type: boolean"
>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: properties:qcom,hs-disconnect-bp: 'oneOf' conditional failed, one must be fixed:
>> 'enum' is a required property
>> 'const' is a required property
>> hint: A vendor string property with exact values has an implicit type
>> from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: properties:qcom,hs-disconnect-bp: 'oneOf' conditional failed, one must be fixed:
>> '$ref' is a required property
>> 'allOf' is a required property
>> hint: A vendor property needs a $ref to types.yaml
>> from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
>> hint: Vendor specific properties must have a type and description unless they have a defined, common suffix.
>> from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: properties:qcom,hs-amplitude-bp: 'oneOf' conditional failed, one must be fixed:
>> 'type' is a required property
>> hint: A vendor boolean property can use "type: boolean"
>> Additional properties are not allowed ('maximum', 'minimum' were unexpected)
>> hint: A vendor boolean property can use "type: boolean"
>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: properties:qcom,hs-amplitude-bp: 'oneOf' conditional failed, one must be fixed:
>> 'enum' is a required property
>> 'const' is a required property
>> hint: A vendor string property with exact values has an implicit type
>> from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: properties:qcom,hs-amplitude-bp: 'oneOf' conditional failed, one must be fixed:
>> '$ref' is a required property
>> 'allOf' is a required property
>> hint: A vendor property needs a $ref to types.yaml
>> from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
>> hint: Vendor specific properties must have a type and description unless they have a defined, common suffix.
>> from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: properties:qcom,pre-emphasis-duration-bp: 'oneOf' conditional failed, one must be fixed:
>> 'type' is a required property
>> hint: A vendor boolean property can use "type: boolean"
>> Additional properties are not allowed ('maximum', 'minimum' were unexpected)
>> hint: A vendor boolean property can use "type: boolean"
>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: properties:qcom,pre-emphasis-duration-bp: 'oneOf' conditional failed, one must be fixed:
>> 'enum' is a required property
>> 'const' is a required property
>> hint: A vendor string property with exact values has an implicit type
>> from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: properties:qcom,pre-emphasis-duration-bp: 'oneOf' conditional failed, one must be fixed:
>> '$ref' is a required property
>> 'allOf' is a required property
>> hint: A vendor property needs a $ref to types.yaml
>> from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
>> hint: Vendor specific properties must have a type and description unless they have a defined, common suffix.
>> from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: ignoring, error in schema: properties: qcom,hs-rise-fall-time-bp
>> Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.example.dtb:0:0: /example-0/phy@88e2000: failed to match any schema with compatible: ['qcom,sm8150-usb-hs-phy']
> Ignore these. A tool issue which is now fixed.
>
> Rob

\
 
 \ /
  Last update: 2022-06-01 19:39    [W:0.090 / U:2.600 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site