lkml.org 
[lkml]   [2022]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] i3c: master: svc: fix returnvar.cocci warning
Hi,

guozhengkui@vivo.com wrote on Thu, 5 May 2022 00:49:01 +0800:

> Fix the following coccicheck warning:
>
> drivers/i3c/master/svc-i3c-master.c:1600:5-8:
> Unneeded variable: "ret". Return "0" on line 1605.
>
> Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
> ---
> drivers/i3c/master/svc-i3c-master.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
> index 7550dad64ecf..d6e9ed74cdcf 100644
> --- a/drivers/i3c/master/svc-i3c-master.c
> +++ b/drivers/i3c/master/svc-i3c-master.c
> @@ -1597,12 +1597,11 @@ static int __maybe_unused svc_i3c_runtime_suspend(struct device *dev)
> static int __maybe_unused svc_i3c_runtime_resume(struct device *dev)
> {
> struct svc_i3c_master *master = dev_get_drvdata(dev);
> - int ret = 0;
>
> pinctrl_pm_select_default_state(dev);
> svc_i3c_master_prepare_clks(master);
>
> - return ret;
> + return 0;
> }
>
> static const struct dev_pm_ops svc_i3c_pm_ops = {

Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>

Thanks,
Miquèl

\
 
 \ /
  Last update: 2022-05-09 15:24    [W:0.063 / U:0.600 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site