Messages in this thread | | | Date | Mon, 9 May 2022 18:05:53 +0530 | Subject | Re: [PATCH v2 3/8] perf/amd/ibs: Add support for L3 miss filtering | From | Ravi Bangoria <> |
| |
On 09-May-22 5:35 PM, Peter Zijlstra wrote: > On Mon, May 09, 2022 at 10:19:09AM +0530, Ravi Bangoria wrote: >> diff --git a/arch/x86/include/asm/perf_event.h b/arch/x86/include/asm/perf_event.h >> index b06e4c573add..a24b637a6e1d 100644 >> --- a/arch/x86/include/asm/perf_event.h >> +++ b/arch/x86/include/asm/perf_event.h >> @@ -391,6 +391,7 @@ struct pebs_xmm { >> #define IBS_CAPS_OPBRNFUSE (1U<<8) >> #define IBS_CAPS_FETCHCTLEXTD (1U<<9) >> #define IBS_CAPS_OPDATA4 (1U<<10) >> +#define IBS_CAPS_ZEN4IBSEXTENSIONS (1U<<11) >> >> #define IBS_CAPS_DEFAULT (IBS_CAPS_AVAIL \ >> | IBS_CAPS_FETCHSAM \ > > Would you mind terribly if I do: > > 's/IBS_CAPS_ZEN4IBSEXTENSIONS/IBS_CAPS_ZEN4/' > > on it? Per the IBS_ suffix, we're already talking about IBS, per the > CAPS thing we're talking about capabilities and I'm thinking that makes > EXTENTION somewhat redundant, which then leaves: > > IBS_CAPS_ZEN4
Yeah, IBS_CAPS_ZEN4 is better. Let me know if you want me to respin.
Thanks, Ravi
| |