lkml.org 
[lkml]   [2022]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH 3/3] tty: n_gsm: fix invalid gsmtty_write_room() result
    Date
    > > +#define TX_SIZE		4096    /* Must be power of 2. */
    >
    > Only that I'd not put the macro definition here. But outside the structure.
    >
    > > struct kfifo fifo; /* Queue fifo for the DLCI */

    I have placed it at the field which it affects the same way as the original
    author placed TX_THRESH_HI and TX_THRESH_LO at tx_list within struct gsm_mux.
    I can resubmit this patch, but it was already included in the tty-linux
    branch. Please let me know your opinion on this.

    Best regards,
    Daniel Starke
    \
     
     \ /
      Last update: 2022-05-09 13:12    [W:5.338 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site