Messages in this thread | | | From | "Starke, Daniel" <> | Subject | RE: [PATCH 3/3] tty: n_gsm: fix invalid gsmtty_write_room() result | Date | Mon, 9 May 2022 11:10:15 +0000 |
| |
> > +#define TX_SIZE 4096 /* Must be power of 2. */ > > Only that I'd not put the macro definition here. But outside the structure. > > > struct kfifo fifo; /* Queue fifo for the DLCI */
I have placed it at the field which it affects the same way as the original author placed TX_THRESH_HI and TX_THRESH_LO at tx_list within struct gsm_mux. I can resubmit this patch, but it was already included in the tty-linux branch. Please let me know your opinion on this.
Best regards, Daniel Starke
| |