lkml.org 
[lkml]   [2022]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v2 1/5] dt-bindings: interrupt-controller: Add Renesas RZ/G2L Interrupt Controller
    Hi Prabhakar,

    On Mon, May 9, 2022 at 7:10 AM Lad Prabhakar
    <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
    > Add DT bindings for the Renesas RZ/G2L Interrupt Controller.
    >
    > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
    > Reviewed-by: Rob Herring <robh@kernel.org>

    Thanks for your patch!

    > --- /dev/null
    > +++ b/Documentation/devicetree/bindings/interrupt-controller/renesas,rzg2l-irqc.yaml
    > @@ -0,0 +1,131 @@
    > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
    > +%YAML 1.2
    > +---
    > +$id: http://devicetree.org/schemas/interrupt-controller/renesas,rzg2l-irqc.yaml#
    > +$schema: http://devicetree.org/meta-schemas/core.yaml#
    > +
    > +title: Renesas RZ/G2L (and alike SoC's) Interrupt Controller (IA55)
    > +
    > +maintainers:
    > + - Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
    > + - Geert Uytterhoeven <geert+renesas@glider.be>
    > +
    > +description: |
    > + IA55 performs various interrupt controls including synchronization for the external
    > + interrupts of NMI, IRQ, and GPIOINT and the interrupts of the built-in peripheral
    > + interrupts output by each IP. And it notifies the interrupt to the GIC
    > + - IRQ sense select for 8 external interrupts, mapped to 8 GIC SPI interrupts
    > + - GPIO pins used as external interrupt input pins, mapped to 32 GIC SPI interrupts
    > + - NMI edge select (NMI is not treated as NMI exception and supports fall edge and
    > + stand-up edge detection interrupts)
    > +
    > +allOf:
    > + - $ref: /schemas/interrupt-controller.yaml#
    > +
    > +properties:
    > + compatible:
    > + items:
    > + - enum:
    > + - renesas,r9a07g044-irqc # RZ/G2L
    > + - const: renesas,rzg2l-irqc
    > +
    > + '#interrupt-cells':
    > + const: 2

    Please document the meaning of the cells.

    The rest LGTM, so
    Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

    Gr{oetje,eeting}s,

    Geert

    --
    Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
    -- Linus Torvalds

    \
     
     \ /
      Last update: 2022-05-09 11:39    [W:2.734 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site