Messages in this thread | | | From | Arnd Bergmann <> | Date | Mon, 9 May 2022 11:20:33 +0200 | Subject | Re: [RFC v2 31/39] sound: add HAS_IOPORT dependencies |
| |
On Mon, May 9, 2022 at 10:53 AM Takashi Iwai <tiwai@suse.de> wrote: > On Fri, 29 Apr 2022 15:50:54 +0200, Niklas Schnelle wrote:
> > > > config SND_OPL3_LIB > > tristate > > + depends on HAS_IOPPORT > > select SND_TIMER > > select SND_HWDEP > > select SND_SEQ_DEVICE if SND_SEQUENCER != n > > Both of those are the items to be reverse-selected, so cannot fulfill > the dependency with depends-on. That is, the items that select those > should have the dependency on HAS_IOPORT instead. > > That is, a change like below: > > > --- a/sound/isa/Kconfig > > +++ b/sound/isa/Kconfig > > @@ -31,7 +31,7 @@ if SND_ISA > > > > config SND_ADLIB > > tristate "AdLib FM card" > > - select SND_OPL3_LIB > > + depends on SND_OPL3_LIB > > ... won't work. CONFIG_SND_OPL3_LIB is not enabled by itself but only > to be selected.
Right, I missed that in my review. Not sure if this was a mistake in my original patch or if it started in a later version.
I think for the ISA drivers, I would still add 'depends on HAS_IOPORT' to both CONFIG_SND_ISA and CONFIG_SND_OPL3_LIB if only to make it easier to understand, even though CONFIG_ISA requires HAS_IOPORT already, and CONFIG_SND_OPL3_LIB cannot be selected by itself.
For the PCI drivers, I think we need to add the same dependency on anything that either selects SND_OPL3_LIB or calls inb()/outb() directly.
Arnd
| |