lkml.org 
[lkml]   [2022]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 3/4] tpm: Implement command and response retry in tpm_tis_core
On Fri, May 06, 2022 at 07:00:15PM +0200, Johannes Holland wrote:
> Some errors during command transmission and response reception are
> recoverable. Implement the specified retry mechanisms.
>
> Recoverable errors during response reception:
> * invalid response size during header read
> * left over data:
> a communication error can lead to a FIFO read of 0xFFs and an
> unexpected STS.dataAvail = 1, subsequently
> * CRC mismatch
>
> Recoverable errors during transmit:
> * CRC mismatch
>
> Signed-off-by: Johannes Holland <johannes.holland@infineon.com>

You should split this multiple patch, each implementing one retry
mechanism (CRC's can for recv and transmit can be in a single path
tho):

https://www.kernel.org/doc/html/latest/process/submitting-patches.html#separate-your-changes

BR, Jarkko

\
 
 \ /
  Last update: 2022-05-07 21:56    [W:0.633 / U:0.500 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site