lkml.org 
[lkml]   [2022]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH v4 1/2] dt-bindings: vm-wdt: Add qemu,vm-watchdog compatible
On Fri, Apr 29, 2022 at 08:30:31AM +0000, Sebastian Ene wrote:
> The stall detection mechanism allows to configure the expiration
> duration and the internal counter clock frequency measured in Hz.
> Add these properties in the schema.
>
> Signed-off-by: Sebastian Ene <sebastianene@google.com>
> ---
> .../devicetree/bindings/misc/vm-watchdog.yaml | 45 +++++++++++++++++++
> 1 file changed, 45 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/misc/vm-watchdog.yaml
>
> diff --git a/Documentation/devicetree/bindings/misc/vm-watchdog.yaml b/Documentation/devicetree/bindings/misc/vm-watchdog.yaml
> new file mode 100644
> index 000000000000..d7cca23357ab
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/misc/vm-watchdog.yaml
> @@ -0,0 +1,45 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/misc/vm-watchdog.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: VM watchdog
> +
> +description: |
> + This binding describes a CPU stall detector mechanism for virtual cpus
> + which is accessed through MMIO.
> +
> +maintainers:
> + - Sebastian Ene <sebastianene@google.com>
> +
> +properties:
> + compatible:
> + enum:
> + - qemu,vm-watchdog
> + clock-frequency:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: |
> + The watchdog internal clock measure in Hz used to decrement the
> + watchdog counter register on each tick.
> + Defaults to 10 if unset.
> + timeout-sec:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: |
> + The watchdog expiration timeout measured in seconds.
> + Defaults to 8 if unset.
> +
> +required:
> + - compatible
> +
> +additionalProperties: false
Hi,

> +
> +examples:
> + - |
> + watchdog {
> + compatible = "qemu,vm-watchdog";
> + clock-frequency = <10>;
> + timeout-sec = <8>;
> + };
> +
> +...
> --
> 2.36.0.464.gb9c8b46e94-goog
>

I was thinking to move the properties clock-frequency and timeout-sec as
part of the emulated watchdog registers and keep only the registers
property in the DT.

Thanks,
Seb

\
 
 \ /
  Last update: 2022-05-07 10:17    [W:0.130 / U:0.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site