Messages in this thread | | | From | "Eric W. Biederman" <> | Date | Fri, 06 May 2022 14:42:16 -0500 | Subject | Re: [PATCH v4 10/12] ptrace: Don't change __state |
| |
Oleg Nesterov <oleg@redhat.com> writes:
> On 05/05, Eric W. Biederman wrote: >> >> --- a/include/linux/sched.h >> +++ b/include/linux/sched.h >> @@ -103,7 +103,7 @@ struct task_group; >> /* Convenience macros for the sake of set_current_state: */ >> #define TASK_KILLABLE (TASK_WAKEKILL | TASK_UNINTERRUPTIBLE) >> #define TASK_STOPPED (TASK_WAKEKILL | __TASK_STOPPED) >> -#define TASK_TRACED (TASK_WAKEKILL | __TASK_TRACED) >> +#define TASK_TRACED __TASK_TRACED > > however I personally still dislike this change. But let me read the > code with this series applied, perhaps I will change my mind. If not, > I will argue ;)
That is fair. I kind of grew on my after I implemented it and wrapped my head around what was going on, as it is simple and there are no implicit cases.
Eric
| |