Messages in this thread | | | Date | Fri, 6 May 2022 13:36:37 +0800 | Subject | Re: [PATCH v4 05/11] iommu/sva: Assign a PASID to mm on PASID allocation and free it on mm exit | From | Baolu Lu <> |
| |
On 2022/5/3 15:49, Jean-Philippe Brucker wrote: > On Sat, Apr 30, 2022 at 03:33:17PM +0800, Baolu Lu wrote: >> Jean, another quick question about the iommu_sva_bind_device() >> >> /** >> * iommu_sva_bind_device() - Bind a process address space to a device >> * @dev: the device >> * @mm: the mm to bind, caller must hold a reference to it >> * @drvdata: opaque data pointer to pass to bind callback >> >> This interface requires the caller to take a reference to mm. Which >> reference should it take, mm->mm_count or mm->mm_users? It's better to >> make it explicit in this comment. > > Agreed, it's mm_users as required by mmu_notifier_register()
Thanks! I will add this in my refactoring patch.
Best regards, baolu
| |