lkml.org 
[lkml]   [2022]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] ethernet: tulip: fix missing pci_disable_device() on error in tulip_init_one()
Date
Am Freitag, 6. Mai 2022, 11:42:50 CEST schrieb Yang Yingliang:
> Fix the missing pci_disable_device() before return
> from tulip_init_one() in the error handling case.

I would suggest removing the pci_disable_device() from tulip_remove_one()
instead and using pcim_enable_device(), i.e. devres, and let the driver core
handle all these things. Of course more of the used functions could be
converted them, e.g. using devm_alloc_etherdev() and so on.

Eike[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2022-05-06 12:20    [W:0.078 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site