lkml.org 
[lkml]   [2022]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [RFC PATCH pdx86-platform-drivers-x86] platform/x86: thinkpad_acpi: quirk_s2idle_bug can be static
From
Hi,

On 5/3/22 20:21, kernel test robot wrote:
> drivers/platform/x86/thinkpad_acpi.c:322:20: warning: symbol 'quirk_s2idle_bug' was not declared. Should it be static?
>
> Fixes: a50dfa903391 ("platform/x86: thinkpad_acpi: Add a s2idle resume quirk for a number of laptops")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>

Thanks, since the original patch was still in my review-hans
branch (and not yet in for-next) I've squashed this fix into
the original patch.

Regards,

Hans



> ---
> drivers/platform/x86/thinkpad_acpi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
> index f385450af8647..d5431d3d4246f 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -319,7 +319,7 @@ struct quirk_entry quirk_btusb_bug = {
> .btusb_bug = true,
> };
>
> -struct quirk_entry quirk_s2idle_bug = {
> +static struct quirk_entry quirk_s2idle_bug = {
> .s2idle_bug_mmio = 0xfed80380,
> };
>
>

\
 
 \ /
  Last update: 2022-05-06 12:11    [W:0.063 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site