Messages in this thread | | | Date | Fri, 6 May 2022 12:09:35 +0200 | Subject | Re: [RFC PATCH pdx86-platform-drivers-x86] platform/x86: thinkpad_acpi: quirk_btusb_bug can be static | From | Hans de Goede <> |
| |
Hi,
On 5/3/22 15:07, Limonciello, Mario wrote: > [Public] > > > >> -----Original Message----- >> From: kernel test robot <lkp@intel.com> >> Sent: Tuesday, May 3, 2022 06:18 >> To: Limonciello, Mario <Mario.Limonciello@amd.com> >> Cc: kbuild-all@lists.01.org; Andy Shevchenko >> <andriy.shevchenko@linux.intel.com>; Hans de Goede >> <hdegoede@redhat.com>; linux-kernel@vger.kernel.org >> Subject: [RFC PATCH pdx86-platform-drivers-x86] platform/x86: >> thinkpad_acpi: quirk_btusb_bug can be static >> >> drivers/platform/x86/thinkpad_acpi.c:317:20: warning: symbol >> 'quirk_btusb_bug' was not declared. Should it be static? >> >> Fixes: 25eecc2ff6cc ("platform/x86: thinkpad_acpi: Convert btusb DMI list to >> quirks") >> Reported-by: kernel test robot <lkp@intel.com> >> Signed-off-by: kernel test robot <lkp@intel.com> > > Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
Thanks, since the original patch was still in my review-hans branch (and not yet in for-next) I've squashed this fix into the original patch.
Regards,
Hans
> >> --- >> drivers/platform/x86/thinkpad_acpi.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/platform/x86/thinkpad_acpi.c >> b/drivers/platform/x86/thinkpad_acpi.c >> index aed17d32ed84b..eefa22e86ae10 100644 >> --- a/drivers/platform/x86/thinkpad_acpi.c >> +++ b/drivers/platform/x86/thinkpad_acpi.c >> @@ -314,7 +314,7 @@ struct quirk_entry { >> bool btusb_bug; >> }; >> >> -struct quirk_entry quirk_btusb_bug = { >> +static struct quirk_entry quirk_btusb_bug = { >> .btusb_bug = true, >> }; >> >
| |