Messages in this thread | | | From | Doug Anderson <> | Date | Thu, 5 May 2022 08:44:41 -0700 | Subject | Re: [RFC PATCH] drm/edid: drm_add_modes_noedid() should set lowest resolution as preferred |
| |
Ville,
On Tue, Apr 26, 2022 at 1:21 PM Douglas Anderson <dianders@chromium.org> wrote: > > If we're unable to read the EDID for a display because it's corrupt / > bogus / invalid then we'll add a set of standard modes for the > display. When userspace looks at these modes it doesn't really have a > good concept for which mode to pick and it'll likely pick the highest > resolution one by default. That's probably not ideal because the modes > were purely guesses on the part of the Linux kernel. > > Let's instead set 640x480 as the "preferred" mode when we have no EDID. > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > --- > > drivers/gpu/drm/drm_edid.c | 9 +++++++++ > 1 file changed, 9 insertions(+)
Someone suggested that you might have an opinion on this patch and another one I posted recently [1]. Do you have any thoughts on it? Just to be clear: I'm hoping to land _both_ this patch and [1]. If you don't have an opinion, that's OK too.
[1] https://lore.kernel.org/r/20220426114627.2.I4ac7f55aa446699f8c200a23c10463256f6f439f@changeid
-Doug
| |