Messages in this thread | | | Date | Thu, 5 May 2022 16:24:50 +0200 | From | Andrew Lunn <> | Subject | Re: [RFC PATCH v6 10/11] net: dsa: qca8k: add LEDs support |
| |
On Thu, May 05, 2022 at 03:33:07PM +0200, Ansuel Smith wrote: > On Thu, May 05, 2022 at 03:55:26AM +0200, Andrew Lunn wrote: > > > + ret = fwnode_property_read_string(led, "default-state", &state); > > > > You should probably use led_default_state led_init_default_state_get() > > > > Andrew > > Oh, didn't know it was a thing, is this new? Anyway thanks.
No idea. But my thinking was, you cannot be the first to implement the binding, there probably exists some helpers somewhere...
General rule of thumb: Assume somebody has already been there and done it, you just need to find it and reuse it.
Andrew
| |