Messages in this thread | | | Date | Thu, 5 May 2022 12:16:20 +0200 | Subject | Re: [PATCH v6 11/21] KVM: s390: pci: do initial setup for AEN interpretation | From | Christian Borntraeger <> |
| |
Am 26.04.22 um 22:08 schrieb Matthew Rosato: [...] > +/* Caller must hold the aift lock before calling this function */
When you do a next round, maybe use lockdep_assert_help instead of this comment
> +void kvm_s390_pci_aen_exit(void) > +{ > + unsigned long flags; > + struct kvm_zdev **gait_kzdev; > + > + /* > + * Contents of the aipb remain registered for the life of the host > + * kernel, the information preserved in zpci_aipb and zpci_aif_sbv > + * in case we insert the KVM module again later. Clear the AIFT > + * information and free anything not registered with underlying > + * firmware. > + */ > + spin_lock_irqsave(&aift->gait_lock, flags); > + gait_kzdev = aift->kzdev; > + aift->gait = 0; > + aift->sbv = 0; > + aift->kzdev = 0; > + spin_unlock_irqrestore(&aift->gait_lock, flags); > + > + kfree(gait_kzdev); > +} > +
Otherwise,
Reviewed-by: Christian Borntraeger <borntraeger@linux.ibm.com>
| |