lkml.org 
[lkml]   [2022]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/2] simatic-ipc additions to p2sb apl lake gpio
On Tue, Mar 08, 2022 at 08:35:20PM +0100, Henning Schild wrote:
> This switches the simatic-ipc modules to using the p2sb interface
> introduced by Andy with "platform/x86: introduce p2sb_bar() helper".
>
> It also switches to one apollo lake device to using gpio leds.
>
> I am kind of hoping Andy will take this on top and propose it in his
> series.

First of all, they are not applicable to my current version [1] of the series
(it maybe something changed in the Simatic drivers upstream, because I have got
conflicts there. For the record, I'm using Linux Next as a base.

Second question is could it be possible to split first patch into three, or it
has to be in one?

[1]: https://gitlab.com/andy-shev/next/-/tree/topic/p2sb-next
It would be nice if you can perform another round of testing.

> Henning Schild (2):
> simatic-ipc: convert to use common P2SB accessor
> leds: simatic-ipc-leds-gpio: add GPIO version of Siemens driver
>
> drivers/leds/simple/Kconfig | 11 ++
> drivers/leds/simple/Makefile | 3 +-
> drivers/leds/simple/simatic-ipc-leds-gpio.c | 108 ++++++++++++++++++
> drivers/leds/simple/simatic-ipc-leds.c | 77 +------------
> drivers/platform/x86/simatic-ipc.c | 43 +------
> drivers/watchdog/Kconfig | 1 +
> drivers/watchdog/simatic-ipc-wdt.c | 15 +--
> .../platform_data/x86/simatic-ipc-base.h | 2 -
> 8 files changed, 139 insertions(+), 121 deletions(-)
> create mode 100644 drivers/leds/simple/simatic-ipc-leds-gpio.c
>
> --
> 2.34.1
>

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2022-05-04 14:52    [W:0.257 / U:0.580 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site