lkml.org 
[lkml]   [2022]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mm: don't be stuck to rmap lock on reclaim path
On Wed, May 04, 2022 at 04:32:13AM +0100, Matthew Wilcox wrote:
> On Tue, May 03, 2022 at 10:03:41AM -0700, Minchan Kim wrote:
> > -void rmap_walk(struct folio *folio, const struct rmap_walk_control *rwc);
> > -void rmap_walk_locked(struct folio *folio, const struct rmap_walk_control *rwc);
> > +void rmap_walk(struct folio *folio, struct rmap_walk_control *rwc);
> > +void rmap_walk_locked(struct folio *folio, struct rmap_walk_control *rwc);
>
> I see the build bot already beat me to pointing out why this is wrong,
> but do you not look at git log to figure out why code was changed to be
> the way it is now, before you change it back?

This patch added a new field as out param like compact_control so
the rmap_walk_control is not immutable.

\
 
 \ /
  Last update: 2022-05-04 06:31    [W:0.104 / U:0.436 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site