lkml.org 
[lkml]   [2022]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 2/3] mm: hugetlb_vmemmap: cleanup hugetlb_free_vmemmap_enabled*
    From
    On 4/4/22 00:46, Muchun Song wrote:
    > The word of "free" is not expressive enough to express the feature of optimizing
    > vmemmap pages associated with each HugeTLB, rename this keywork to "optimeze".
    > In this patch , cheanup the static key and hugetlb_free_vmemmap_enabled() to make
    > code more expressive.

    Commit message might look better as:

    The keyword "free" is not expressive enough to describe the feature of
    optimizing vmemmap pages associated with each HugeTLB page. Rename the
    keyword to "optimize".

    Rename the static key and hugetlb_free_vmemmap_enabled() to make the code
    more expressive.

    >
    > Signed-off-by: Muchun Song <songmuchun@bytedance.com>
    > ---
    > arch/arm64/mm/flush.c | 2 +-
    > include/linux/page-flags.h | 12 ++++++------
    > mm/hugetlb_vmemmap.c | 10 +++++-----
    > mm/memory_hotplug.c | 2 +-
    > 4 files changed, 13 insertions(+), 13 deletions(-)

    Code changes look fine,

    Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>

    --
    Mike Kravetz

    \
     
     \ /
      Last update: 2022-06-01 02:22    [W:2.892 / U:0.212 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site