lkml.org 
[lkml]   [2022]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/3] mm: hugetlb_vmemmap: cleanup hugetlb_vmemmap related functions
From
On 5/31/22 16:47, Mike Kravetz wrote:
> On 4/4/22 00:46, Muchun Song wrote:
>> The word of "free" is not expressive enough to express the feature of optimizing
>> vmemmap pages associated with each HugeTLB, rename this keywork to "optimeze".
>> And some function names are prefixed with "huge_page" instead of "hugetlb", it is
>> easily to be confused with THP. In this patch , cheanup related functions to make
>> code more clear and expressive.
>
> Some typos in the commit message. Might be better as:
>
> The keyword "free" is not expressive enough to describe the feature of optimizing vmemmap pages associated with each HugeTLB page. Rename the
> keyword to "optimize".
>
> Some function names are prefixed with "huge_page" instead of "hugetlb". These can easily be confused with THP. Change function names to make
> code more clear and expressive.
>

Sorry for the long lines :(

--
Mike Kravetz

\
 
 \ /
  Last update: 2022-06-01 01:59    [W:0.439 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site