Messages in this thread | | | Date | Tue, 31 May 2022 14:10:41 -0700 | From | Dmitry Torokhov <> | Subject | Re: [PATCH -next] Input: joystick: Raspberry Pi Sense HAT depends on HAS_IOMEM |
| |
On Mon, May 30, 2022 at 07:29:42PM -0700, Randy Dunlap wrote: > Since JOYSTICK_SENSEHAT selects MFD_SIMPLE_MFD_I2C and the latter > depends on HAS_IOMEM, and since 'select' does not follow any > dependency chains, JOYSTICK_SENSEHAT should also depend on HAS_IOMEM > to prevent a kconfig warning and a build error: > > WARNING: unmet direct dependencies detected for MFD_SIMPLE_MFD_I2C > Depends on [n]: HAS_IOMEM [=n] && I2C [=y] > Selected by [y]: > - JOYSTICK_SENSEHAT [=y] && INPUT_JOYSTICK [=y] && INPUT [=y] && I2C [=y] > > s390-linux-ld: drivers/mfd/simple-mfd-i2c.o: in function `simple_mfd_i2c_probe': > simple-mfd-i2c.c:(.text+0xc8): undefined reference to `devm_mfd_add_devices' > > Fixes: 41657514c796 ("Input: add Raspberry Pi Sense HAT joystick driver") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Charles Mirabile <cmirabil@redhat.com> > Cc: Daniel Bauman <dbauman@redhat.com> > Cc: Mwesigwa Guma <mguma@redhat.com> > Cc: Joel Savitz <jsavitz@redhat.com> > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> > Cc: linux-input@vger.kernel.org
Applied, thank you.
-- Dmitry
| |