lkml.org 
[lkml]   [2022]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 0/2] Fix some compile warnings in v5.18+
On Mon, May 30, 2022 at 08:31:01PM -0500, Larry Finger wrote:
> Building driver r8188eu in staging with -warray-bounds exposes two places
> where arrays are too small.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
> v2 - get proper To and Cc
> v3 - Use Dan Carpenter's suggestion for correct patch.
>
> Larry Finger (2):
> staging: r8188eu: Fix undersized array in rtw_xmit.c
> staging: r8188eu: Fix warning of array overflow in ioctl_linux.c
>
> drivers/staging/r8188eu/core/rtw_xmit.c | 17 ++++-------------
> drivers/staging/r8188eu/os_dep/ioctl_linux.c | 2 +-
> 2 files changed, 5 insertions(+), 14 deletions(-)
>
> --
> 2.36.1
>

Hi Larry,

Both patches look good to me, however I've already submitted a patch 10
days ago that does exactly what your rtw_xmit.c patch does, in
addition to fixing the changed error handling semantics for the relevant
function (in f94b47c6bde6) which broke the driver.

Regards,
Phil

\
 
 \ /
  Last update: 2022-05-31 08:40    [W:0.091 / U:0.680 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site