Messages in this thread Patch in this message | | | From | Linyu Yuan <> | Subject | [PATCH v3 1/3] tracing: eprobe: remove duplicate is_good_name() operation | Date | Tue, 31 May 2022 14:29:10 +0800 |
| |
traceprobe_parse_event_name() already validate group and event name, there is no need to call is_good_name() after it.
Signed-off-by: Linyu Yuan <quic_linyyuan@quicinc.com> --- v2: drop v1 change as it is NACK. add it to remove duplicate is_good_name(). v3: move it as first patch.
kernel/trace/trace_eprobe.c | 4 ---- 1 file changed, 4 deletions(-)
diff --git a/kernel/trace/trace_eprobe.c b/kernel/trace/trace_eprobe.c index 7d44785..17d64e3 100644 --- a/kernel/trace/trace_eprobe.c +++ b/kernel/trace/trace_eprobe.c @@ -878,16 +878,12 @@ static int __trace_eprobe_create(int argc, const char *argv[]) sanitize_event_name(buf1); event = buf1; } - if (!is_good_name(event) || !is_good_name(group)) - goto parse_error; sys_event = argv[1]; ret = traceprobe_parse_event_name(&sys_event, &sys_name, buf2, sys_event - argv[1]); if (ret || !sys_name) goto parse_error; - if (!is_good_name(sys_event) || !is_good_name(sys_name)) - goto parse_error; mutex_lock(&event_mutex); event_call = find_and_get_event(sys_name, sys_event); -- 2.7.4
| |