Messages in this thread | | | From | Dmitry Rokosov <> | Subject | Re: [PATCH v2 0/5] iio: treewide: rearrange iio trig get/register | Date | Tue, 31 May 2022 18:20:34 +0000 |
| |
Jonathan,
I've submitted the patch with runtime WARN() as you suggested:
https://lore.kernel.org/linux-iio/20220531181457.26034-1-ddrokosov@sberdevices.ru/
On Sat, May 28, 2022 at 06:10:04PM +0100, Jonathan Cameron wrote: > > If this call order is wrong, the next iio_trigger_put() (from sysfs > > callback or "delete module" path) will dereference "default" module > > refcnt, which is incorrect behaviour. > > Hi Dmitry, > > Series applied to the fixes-togreg branch of iio.git and marked for stable. > > Do you think it's also worth adding a runtime warning in iio_trigger_get() > on !trig->owner so that we catch any cases of this introduced in the future? >
-- Thank you, Dmitry
| |