Messages in this thread | | | Date | Wed, 1 Jun 2022 01:58:39 +0800 | From | kernel test robot <> | Subject | Re: [PATCH 4/4] serial: max310x: implement I2C support |
| |
Hi Cosmin,
I love your patch! Perhaps something to improve:
[auto build test WARNING on tty/tty-testing] [also build test WARNING on usb/usb-testing v5.18 next-20220531] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/Cosmin-Tanislav/serial-max310x-use-regmap-methods-for-SPI-batch-operations/20220531-061619 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing config: arm64-allmodconfig (https://download.01.org/0day-ci/archive/20220601/202206010102.px37QPmH-lkp@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project c825abd6b0198fb088d9752f556a70705bc99dfd) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm64 cross compiling tool for clang build # apt-get install binutils-aarch64-linux-gnu # https://github.com/intel-lab-lkp/linux/commit/6c293b95fc5654df5353ba273a9bbd08f1cd3f3a git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Cosmin-Tanislav/serial-max310x-use-regmap-methods-for-SPI-batch-operations/20220531-061619 git checkout 6c293b95fc5654df5353ba273a9bbd08f1cd3f3a # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/tty/serial/
If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/tty/serial/max310x.c:1658:1: warning: unused label 'err_i2c_register' [-Wunused-label] err_i2c_register: ^~~~~~~~~~~~~~~~~ 1 warning generated.
vim +/err_i2c_register +1658 drivers/tty/serial/max310x.c
1652 1653 return 0; 1654 1655 err_spi_register: 1656 spi_unregister_driver(&max310x_spi_driver); 1657 > 1658 err_i2c_register: 1659 uart_unregister_driver(&max310x_uart); 1660 1661 return ret; 1662 } 1663 module_init(max310x_uart_init); 1664
-- 0-DAY CI Kernel Test Service https://01.org/lkp
| |